fix gts ts imports issue

[patricklx]

run the processing in pre to ensure we have the imports before other plugin runs.

fixes embroider-build/ember-auto-import#611

[patricklx]

this ensures that newly added identifiers do actually reference the import binding. Otherwise ts plugin will remove the import

[patricklx]

this identifiers are also added by babel import util

[patricklx]

This is only a problem because we do this in pre

[patricklx]

This is running in pre as well. So it only affects identifiers added during ast transform

[patricklx]

i could also have my own custom plugins that do some babel ast changes during template transform

[ef4]

Can we add a test that runs our plugin and babel-plugin-transform-typescript together so that we don't regress on this bug?

[patricklx]

Can we add a test that runs our plugin and babel-plugin-transform-typescript together so that we don't regress on this bug?

We have it already

babel-plugin-ember-template-compilation/__tests__/tests.ts

Line 1847 in 5fceb59

it('interoperates correctly with @babel/plugin-transform-typescript when handling locals with wire target', function () {

We probably would need another plugin that wants to use the imports.

[NullVoxPopuli]

We have it already

it wasn't failing? 😅

[patricklx]

We have it already

it wasn't failing? 😅

No, because it's not a problem of ts plugin + this plugin. But a problem of
ts plugin + other plugin+ this plugin.

Updated the description

[ef4]

Let me rephrase my question: can we add a test they would fail without these changes?

[patricklx]

@ef4 added a test

[ef4]

Thanks, I found a way to use babel's scope.crawl() to update bindings for only the sub-trees of the AST that we're altering.