Skip to content

update to the latest puppeteer#486

Merged
mansona merged 1 commit intoember-codemods:masterfrom
mansona:update-puppeteer
Jul 11, 2022
Merged

update to the latest puppeteer#486
mansona merged 1 commit intoember-codemods:masterfrom
mansona:update-puppeteer

Conversation

@mansona
Copy link
Copy Markdown
Member

@mansona mansona commented Jul 8, 2022

You need at least puppeteer@15.3.2 to be able to run this codemod on an M1 Mac

puppeteer/puppeteer@9a8479a

@mansona
Copy link
Copy Markdown
Member Author

mansona commented Jul 9, 2022

So it turns out that the latest puppeteer only supports non EOL Node versions (I know right! 🙄) so we should possibly consider doing the same. I opened a PR to do that #490

@mansona mansona force-pushed the update-puppeteer branch from c9b6095 to e6fe9fd Compare July 11, 2022 09:29
@mansona mansona merged commit 515c200 into ember-codemods:master Jul 11, 2022
@mansona mansona deleted the update-puppeteer branch July 11, 2022 15:33
@pmusaraj
Copy link
Copy Markdown

@mansona does this need a new version bumped and published to NPM for people like myself to be able to use it when doing npx ember-native-class-codemod ...? Because when I currently run the command on an M1 machine, I still get a puppeteer error and the package points to the version published in NPM ~1 year ago.

@mansona
Copy link
Copy Markdown
Member Author

mansona commented Jul 26, 2022

Yes exactly, I'm in the process of getting npm publish rights for this to solve that problem for you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants