Improve chrono integration into embassy-rp #5345
Open
+24
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fakusb
force-pushed
the
fix-chrono-main
branch
from
a0970cd to
a9cba2f
Compare
Member
|
can you add the previously-failing feature combinations here so they don't regress again? https://github.com/embassy-rs/embassy/blob/main/embassy-rp/Cargo.toml#L13 |
Contributor
Author
|
I'll have a look into fixing the warnings later today or this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs are fixed here:
Moninstead ofMondayIn theory, it would be nice if the crate would be build with the chrono feature enabled in the CI, but I do neither know how I would achieve this, nor if this is desired.
Furthermore, the chrono feature for embassy-rp changes the public api (e.g. the examples do not compile anymore), but this is true regardless of this MR.