Skip to content

nrf/i2s: allow master mode without MCK pin #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

nrf/i2s: allow master mode without MCK pin #4843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions embassy-nrf/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- bugfix: Do not write to UICR from non-secure code on nrf53
- bugfix: Add delay to uart init anomaly fix
- changed: `BufferedUarte::read_ready` now uses the same definition for 'empty' so following read calls will not block when true is returned
- changed: allow configuring I2S in master mode without master clock output pin

## 0.8.0 - 2025-09-30

Expand Down
4 changes: 2 additions & 2 deletions embassy-nrf/src/i2s.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ impl<'d> I2S<'d> {
pub fn new_master<T: Instance>(
_i2s: Peri<'d, T>,
_irq: impl interrupt::typelevel::Binding<T::Interrupt, InterruptHandler<T>> + 'd,
mck: Peri<'d, impl GpioPin>,
mck: Option<Peri<'d, impl GpioPin>>,
sck: Peri<'d, impl GpioPin>,
lrck: Peri<'d, impl GpioPin>,
master_clock: MasterClock,
Expand All @@ -434,7 +434,7 @@ impl<'d> I2S<'d> {
Self {
r: T::regs(),
state: T::state(),
mck: Some(mck.into()),
mck: mck.map(|mck| mck.into()),
sck: sck.into(),
lrck: lrck.into(),
sdin: None,
Expand Down