Support 8 byte and 16 byte alignment with compact chunk header#21
Merged
Conversation
Member
lulf
commented
Feb 4, 2026
lulf
commented
- Support 8 and 16 byte alignment for headers
- Chunk header + first part of data is now written together to reduce unnecessary padding for chunks.
Refactors chunk header to pad the chunk after header + data, to avoid unnecessary padding that is wasteful at 16 byte alignment.
Dirbaio
requested changes
Feb 5, 2026
Address review feedback: - Remove repr(align(N)) from MetaHeader and DataHeader We only need size to be a multiple of ALIGN, not RAM alignment - Replace dataheader_padding_align with calc_padding that: * Works for any alignment value (including future align-32+) * Evaluates to 0 when no padding is needed * Doesn't require cfg guards - Simplify struct initialization by removing cfg attributes This approach is more maintainable and will work seamlessly when adding support for higher alignment values. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.