Update http and git sources only once#5
Open
bugadani wants to merge 1 commit intoembassy-rs:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent redundant updates of remote package sources within a single Cargo session by tracking which sources have already been updated in GlobalContext::updated_sources().
Changes:
- Add
is_updated/mark_updatedhelpers to HTTP sparse registry handling and use them to short-circuit repeated “update” work. - Add
is_updated/mark_updatedhelpers to git dependency handling and use them to avoid re-updating when resolving a deferred git reference multiple times in one session.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/cargo/sources/registry/http_remote.rs |
Adds per-session updated-source tracking and attempts to skip repeated HTTP registry update setup. |
src/cargo/sources/git/source.rs |
Adds per-session updated-source tracking and avoids repeated git updates when resolving deferred refs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is supposed to fix this nonsense by checking if a remote registry has already been updated, where the check was missing before.