Skip to content

Update http and git sources only once#5

Open
bugadani wants to merge 1 commit intoembassy-rs:masterfrom
bugadani:checkout-once
Open

Update http and git sources only once#5
bugadani wants to merge 1 commit intoembassy-rs:masterfrom
bugadani:checkout-once

Conversation

@bugadani
Copy link

@bugadani bugadani commented Feb 3, 2026

This PR is supposed to fix this nonsense by checking if a remote registry has already been updated, where the check was missing before.

Copilot AI review requested due to automatic review settings February 3, 2026 18:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent redundant updates of remote package sources within a single Cargo session by tracking which sources have already been updated in GlobalContext::updated_sources().

Changes:

  • Add is_updated/mark_updated helpers to HTTP sparse registry handling and use them to short-circuit repeated “update” work.
  • Add is_updated/mark_updated helpers to git dependency handling and use them to avoid re-updating when resolving a deferred git reference multiple times in one session.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/cargo/sources/registry/http_remote.rs Adds per-session updated-source tracking and attempts to skip repeated HTTP registry update setup.
src/cargo/sources/git/source.rs Adds per-session updated-source tracking and avoids repeated git updates when resolving deferred refs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant