Add customization for God mode's minor mode lighter #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a face for the lighter, and allow the lighter string to be customized. Also update README describing these customizations.
darth10
reviewed
Dec 29, 2022
darth10
reviewed
Dec 29, 2022
darth10
reviewed
Dec 29, 2022
There was a problem hiding this comment.
This is a nice improvement @luispauloml!
There are a few minor comments I've made, but LGTM other than that. 💯
|
@darth10, I've added a new commit with the changes you requested that you can squash with the original one. Or actually, should I squash them myself? |
No worries, I'll squash them all after a quick review! |
darth10
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
God mode's README makes a few suggestions on how to set up visual indicators but none of them are actually provided by the package itself. Emacs's default visual indicators for modes are their lighters, so I thought it would be good to allow the customization of the face and the string of God mode's lighter, and this is what this patch does:
god-mode-lighter-stringvariable to allow the change the string "God" or to completely disable the lighter,god-mode-lighterface to allow the user change the face of the lighter.If a user had already setup another visual indicator and had removed God mode's lighter by deleting it from
minor-mode-alist, now it is easier to hide it by just settinggod-mode-lighter-stringto nil.As an example of the results, you can see below what I do: I use Emacs's default theme and Nano Theme light and I set
god-mode-lighterto inherit fromerrorandnano-critical-ifor each theme, respectively. Also, I updated the README and actually added an example of how to set the new face to inherit fromerror, which is the most contrasting default face in Emacs that I could find.