Fix error if god-execute-with-current-bindings deletes buffer#118
Fix error if god-execute-with-current-bindings deletes buffer#118darth10 merged 1 commit intoemacsorphanage:masterfrom fullmera:dead_buffer_fix
Conversation
|
Thanks for reporting and fixing this bug @Drainful! |
|
I'm not sure how to write a test since the error isn't caught by debug-on-error. It seems like the only artifact of the error is the annoying message in the minibuffer as it goes unhandled. I'm not sure why this is the case; it may have something to do with the error being raised during the function passed as the |
|
This might be easier to test with |
|
Thanks for the contribution @Drainful! 💯 |
|
NP! thanks for your work on this awesome package. I feel like god-mode has filled a massive hole in my emacs config. |
Currently if a command executed via
god-execute-with-current-bindingsresults in the deletion of the current buffer, an error message is spat out in the minibuffer. This commit updates the cleanup process ofgod-execute-with-current-bindingsto check if the buffer exists and is alive before disabling god-local-mode.Fixes #117