Fix god-mode-upper-p's use of god-mode-alist#116
Merged
darth10 merged 2 commits intoemacsorphanage:masterfrom Jul 4, 2020
Merged
Fix god-mode-upper-p's use of god-mode-alist#116darth10 merged 2 commits intoemacsorphanage:masterfrom
darth10 merged 2 commits intoemacsorphanage:masterfrom
Conversation
The relatively recent change to remove hard-coding the `?G` character broke handling of that character. It impacted me because if I set mark, then moved point forward by a word, and then moved point forward by a sexp using `G f`, mark would be reset to the location of point when I issued the `G f` command. For example, say you have the string "Here we go" in a buffer. Put point before the word "Here", then, in `god-mode`, hit space to activate mark, then hit "g f" to move point forward by a word. The region will cover the word "Here". If you then hit "G f", the region will move forward but no longer include include the word "Here". Looking at the code, there is a problem because the keys of `god-mode-alist` are strings while `key` in `god-mode-upper-p` is a character. We could either make the change I have made here, or make the keys of `god-mode-alist` characters.
Collaborator
|
Thanks for the contribution @acowley! The changes look good after a quick test. |
Contributor
Author
|
I have added a test implementing the scenario I described in the original commit message. |
darth10
approved these changes
Jul 4, 2020
Collaborator
|
Thanks again @acowley! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The relatively recent change to remove hard-coding the
?Gcharacter broke handling of that character. It impacted me because if I set mark, then moved point forward by a word, and then moved point forward by a sexp usingG f, mark would be reset to the location of point when I issued theG fcommand.For example, say you have the string "Here we go" in a buffer. Put point before the word "Here", then, in
god-mode, hit space to activate mark, then hit "g f" to move point forward by a word. The region will cover the word "Here". If you then hit "G f", the region will move forward but no longer include include the word "Here".Looking at the code, there is a problem because the keys of
god-mode-alistare strings whilekeyingod-mode-upper-pis a character. We could either make the change I have made here, or make the keys ofgod-mode-alistcharacters.