Make org keybindings and integration optional #572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnicandro
reviewed
Dec 1, 2025
|
|
||
| (add-hook 'org-export-before-processing-functions #'org-babel-jupyter-setup-export) | ||
| (add-hook 'org-export-before-parsing-functions #'org-babel-jupyter-strip-ansi-escapes) | ||
| (when jupyter-org-want-integration |
Collaborator
There was a problem hiding this comment.
Why should this be here? There would be no way to recognize Jupyter source blocks in the buffer if we don't make the aliases at some point and the other hooks only apply for Jupyter specific source blocks as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two variables to control the integration with org:
which are true by default to keep the old behavior.
I believe org interaction should be optional because any breakage in jupyter package causes issues with org and that is a very frustrating experience for heavy org users. Now with these variables, user can disable the integration for the time being or they can simply turn it on manually on demand.