-
Notifications
You must be signed in to change notification settings - Fork 360
nbconvert version without lxml requirement and more #3240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nbconvert version without lxml requirement and more #3240
Conversation
7bfdebc to
f2fa297
Compare
|
@harshad16 @lresende @romeokienzler @kevin-bates does Elyra still need to work with Python 3.8? https://github.com/elyra-ai/elyra/actions/runs/10460646800/job/28967259508?pr=3240 I don't know anyone still using Python 3.8. Its end of life is in October 2024 https://devguide.python.org/versions/ With regards to Jupyter-Core, ipython and so on, it is now a similar situation with python 3.8 as it was back then with Python 3.7. In any case, everything from ipython 8.13.1 on https://pypi.org/project/ipython/8.13.1/ does not work with Python 3.8 anymore ... so, keeping ipython at just the version before that for now. |
requirements and pyproject dependencies to be more current while being Jupyterlab <4 compatible and keeping Python 3.8 compatibility for now. Signed-off-by: shalberd <[email protected]>
03cc97b to
f61a22d
Compare
Signed-off-by: shalberd <[email protected]>
|
reasoning for requests update: https://github.com/psf/requests/releases 2.32.0 was yanked |
|
Tested built wheel file with Jupyterlab 3.6.5 and elyra requirements baked into a runtime file with Python 3.9, no problem on Airflow. Python and ipynb executed without issues. |
…#3240) * nbconvert version without lxml requirement. Update runtime library requirements and pyproject dependencies to be more current. --------- Signed-off-by: shalberd <[email protected]>
…#3240) * nbconvert version without lxml requirement. Update runtime library requirements and pyproject dependencies to be more current. --------- Signed-off-by: shalberd <[email protected]>
* chores: set temporary default for elyra-branch as jupyterlab4 Signed-off-by: Harshad Reddy Nalla <[email protected]> * Dependency updates including nbconvert version without lxml (elyra-ai#3240) * nbconvert version without lxml requirement. Update runtime library requirements and pyproject dependencies to be more current. --------- Signed-off-by: shalberd <[email protected]> --------- Signed-off-by: Harshad Reddy Nalla <[email protected]> Signed-off-by: shalberd <[email protected]> Co-authored-by: Sven Thoms <[email protected]>
* chores: set temporary default for elyra-branch as jupyterlab4 Signed-off-by: Harshad Reddy Nalla <[email protected]> * Dependency updates including nbconvert version without lxml (elyra-ai#3240) * nbconvert version without lxml requirement. Update runtime library requirements and pyproject dependencies to be more current. --------- Signed-off-by: shalberd <[email protected]> --------- Signed-off-by: Harshad Reddy Nalla <[email protected]> Signed-off-by: shalberd <[email protected]> Co-authored-by: Sven Thoms <[email protected]>
* chores: set temporary default for elyra-branch as jupyterlab4 Signed-off-by: Harshad Reddy Nalla <[email protected]> * Dependency updates including nbconvert version without lxml (elyra-ai#3240) * nbconvert version without lxml requirement. Update runtime library requirements and pyproject dependencies to be more current. --------- Signed-off-by: shalberd <[email protected]> --------- Signed-off-by: Harshad Reddy Nalla <[email protected]> Signed-off-by: shalberd <[email protected]> Co-authored-by: Sven Thoms <[email protected]>
fixes #3228
closes #3214
Also discussed but never merged in PR 3214
nbconvert version is in use at ODH and in my organization without any issues in relation to Jupyterlab and runtime images.
Also, putting in some recent jupyter* library updates that are still Jupyterlab < 4 compatible, no collisions with Jupyterlab
3.6.5
Keeping Python 3.8 compatibility in here, seperating discussion on that for later.
This is used in Red Hat Open Data Hub Notebook images
https://github.com/opendatahub-io/elyra/blob/dspv2/etc/generic/requirements-elyra.txt
https://github.com/opendatahub-io/elyra/blob/dspv2/pyproject.toml#L30
https://github.com/opendatahub-io/notebooks/blob/main/jupyter/datascience/ubi9-python-3.9/Pipfile#L29
and the Jupyter* updates (jupyter-client, jupyter-core ... ) are working well, stemming from ODH contrib, working well
and tested by me to not conflict with Jupyterlab 3.5, confirmed with pipenv.
https://github.com/opendatahub-io-contrib/workbench-images/blob/main/snippets/bundles/2-datascience/py39/requirements-jupyter.txt#L90
https://github.com/opendatahub-io-contrib/workbench-images/blob/main/DEVELOPMENT.md
@harshad16 have not put in any KFP 2.0 dependencies in here yet, as the idea would be for latest / 3.16.0 maybe, but not elyra 4.0.
What changes were proposed in this pull request?
There was a needed update to nbconvert cause it required lxml. fixing nbconvert to 7.1.0 makes sures that lxml itself is not needed anymore and also that it is still compatible with kfp less than 2 and jupyterlab less than 4in terms of python.
How was this pull request tested?
Having this running in an ODH Contrib Jupyterlab 3.6.5 environment. Gitlab plugin working fine, requirements-elyra working fine in runtime images executing iypnb notebooks in Airflow 2.x.
Developer's Certificate of Origin 1.1