Skip to content

Conversation

@akchinSTC
Copy link
Member

Signed-off-by: Alan Chin [email protected]

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC akchinSTC added the component:build build and build related issues(dependencies and docker) label Jan 20, 2023
@ptitzler ptitzler self-requested a review January 23, 2023 15:50
Signed-off-by: Alan Chin <[email protected]>
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that make container-images yields the expected output when the Makefile is modified as follows to use podman:

CONTAINER_EXEC?=podman
CONTAINER_OUTPUT_OPTION?=--format docker

Signed-off-by: Alan Chin <[email protected]>
@kevin-bates
Copy link
Member

Thanks @ptitzler. These should also be settable on the command itself so that no Makefile changes are necessary.

make CONTAINER_EXEC=podman CONTAINER_OUTPUT_OPTION="--format docker" container-images

@ptitzler
Copy link
Member

Thanks @ptitzler. These should also be settable on the command itself so that no Makefile changes are necessary.

make CONTAINER_EXEC=podman CONTAINER_OUTPUT_OPTION="--format docker" container-images

I agree, but my thinking was that whoever uses podman would probably rather modify the Makefile onceto avoid the need to pass the custom options every single time container images need to be build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:build build and build related issues(dependencies and docker)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants