Skip to content

Conversation

@akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Jan 10, 2023

Signed-off-by: Alan Chin [email protected]

Closes #3074

  • Update documentation

What changes were proposed in this pull request?

Update factory runtime images to use SHA256 hashes instead of the tag name.
Human readable name still exists in the form of the display_name.

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC akchinSTC added kind:enhancement New feature or request platform: Open Data Hub component:runtime-image Issues related to container images used to run generic components labels Jan 10, 2023
@shalberd
Copy link
Contributor

The image tests are fine now. There are some Elyra tests that seem to not be ok, but that is unrelated to our changes, I think.
Bildschirmfoto 2023-01-11 um 00 14 38

Signed-off-by: Alan Chin <[email protected]>
Signed-off-by: Alan Chin <[email protected]>
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM. I do agree with @shalberd that the description of Image Name should be amended with or name and SHA256-digest for consistency.

@shalberd
Copy link
Contributor

shalberd commented Jan 11, 2023

Looking good, now the only integration test failing is https://github.com/elyra-ai/elyra/blob/main/tests/integration/pipeline.ts#L135 complex pipeline test stuff

@shalberd
Copy link
Contributor

These changes LGTM. I do agree with @shalberd that the description of Image Name should be amended with or name and SHA256-digest for consistency.

Yes, I think that short addition is a good idea in terms of being brief and terse.

Signed-off-by: Alan Chin <[email protected]>
Signed-off-by: Alan Chin <[email protected]>
@shalberd
Copy link
Contributor

shalberd commented Jan 13, 2023

LGTM, can be merged, thanks to you two, great.

@akchinSTC akchinSTC merged commit f369c96 into elyra-ai:main Jan 13, 2023
@ptitzler ptitzler added this to the 3.14.2 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:runtime-image Issues related to container images used to run generic components kind:enhancement New feature or request platform: Open Data Hub

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define runtime images in sha256 digest instead of tag format

4 participants