-
Notifications
You must be signed in to change notification settings - Fork 359
Update factory image tags to use SHA256 hashes #3075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alan Chin <[email protected]>
Signed-off-by: Alan Chin <[email protected]>
Signed-off-by: Alan Chin <[email protected]>
Signed-off-by: Alan Chin <[email protected]>
Signed-off-by: Alan Chin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM. I do agree with @shalberd that the description of Image Name should be amended with or name and SHA256-digest for consistency.
|
Looking good, now the only integration test failing is https://github.com/elyra-ai/elyra/blob/main/tests/integration/pipeline.ts#L135 complex pipeline test stuff |
Yes, I think that short addition is a good idea in terms of being brief and terse. |
Signed-off-by: Alan Chin <[email protected]>
Signed-off-by: Alan Chin <[email protected]>
|
LGTM, can be merged, thanks to you two, great. |

Signed-off-by: Alan Chin [email protected]
Closes #3074
What changes were proposed in this pull request?
Update factory runtime images to use SHA256 hashes instead of the tag name.
Human readable name still exists in the form of the display_name.
How was this pull request tested?
Developer's Certificate of Origin 1.1