Skip to content

Conversation

@akchinSTC
Copy link
Member

Signed-off-by: Alan Chin [email protected]

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC akchinSTC added the component:test Test-related label Jan 9, 2023
@lresende
Copy link
Member

lresende commented Jan 9, 2023

Instead of disabling it, should we fix the not so good hardcoded versions?

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good and I agree that we can circle back and address this single test correctly via #3072. We just have way too many test failures piling up for various other things.

PR #3076 should be merged BEFORE this one, otherwise, we won't see the test skipped and a successful pass.

@akchinSTC akchinSTC merged commit 099095c into elyra-ai:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:test Test-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants