Properly escape string property inputs#3048
Merged
Merged
Conversation
Signed-off-by: Patrick Titzler <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
kiersten-stokes
approved these changes
Dec 9, 2022
Member
kiersten-stokes
left a comment
There was a problem hiding this comment.
Tested several components and strings are properly delimited!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3047
Signed-off-by: Patrick Titzler [email protected]
What changes were proposed in this pull request?
Escape user-provided property values that are of type
string:How was this pull request tested?
Using the component spec referenced in the original issue, I've specified valid JSON strings as input, such as
{"test_dict": 99}and["array_item_1", "array_item_2"].Developer's Certificate of Origin 1.1