Skip to content

Conversation

@ptitzler
Copy link
Member

This PR updates pipeline validation as follows.

  • For generic components file dependencies text files or binary files are considered valid input, as shown below:

    Screenshot 2022-11-21 at 11 25 16
  • For custom components input files only text files are considered valid input. The example below would trigger a validation error:

Screenshot 2022-11-21 at 11 26 39

Closes #3020

Signed-off-by: Patrick Titzler [email protected]

What changes were proposed in this pull request?

  • See above

How was this pull request tested?

  • Manual testing
  • Added/updated validation tests

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added the kind:bug Something isn't working label Nov 21, 2022
@ptitzler ptitzler added this to the 3.14.0 milestone Nov 21, 2022
@elyra-bot
Copy link

elyra-bot bot commented Nov 21, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler changed the title Reject binary property input files Validation: reject binary property input files for custom components Nov 21, 2022
@ptitzler ptitzler added component:pipeline validation Issues related to pipeline validation service sizing: XS labels Nov 21, 2022
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

ptitzler and others added 2 commits November 23, 2022 10:28
Signed-off-by: Patrick Titzler <[email protected]>

Signed-off-by: Patrick Titzler <[email protected]>
Co-authored-by: Kiersten Stokes <[email protected]>
Signed-off-by: Patrick Titzler <[email protected]>
@ptitzler ptitzler force-pushed the reject-binary-input-files branch from f5d7fef to 50b2546 Compare November 23, 2022 18:29
@akchinSTC akchinSTC merged commit 0885484 into elyra-ai:main Nov 28, 2022
@ptitzler ptitzler deleted the reject-binary-input-files branch November 28, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:pipeline validation Issues related to pipeline validation service kind:bug Something isn't working sizing: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pipeline doesn't compile

3 participants