Skip to content

Conversation

@kiersten-stokes
Copy link
Member

@kiersten-stokes kiersten-stokes commented Oct 4, 2022

Fixes an issue raised in this PR comment.

What changes were proposed in this pull request?

A "G" is added to the Airflow DAG template resources argument for the request_memory key.

Docs have also been updated to reflect that the units are in gigabytes for both KFP and Airflow.

Screen Shot 2022-10-04 at 11 59 32 AM

How was this pull request tested?

Ran a pipeline with RAM resource amount specified.

$ kubectl describe pod <pod-name>
...
Ready:          False
    Restart Count:  0
    Requests:
      memory:  3G
    Environment:
      AWS_ACCESS_KEY_ID:           <set to the key 'AWS_ACCESS_KEY_ID' in secret 'airflow-cos-secret'>      Optional: false
      AWS_SECRET_ACCESS_KEY:       <set to the key 'AWS_SECRET_ACCESS_KEY' in secret 'airflow-cos-secret'>  Optional: false
      ELYRA_ENABLE_PIPELINE_INFO:  True
      ELYRA_RUNTIME_ENV:           airflow
      ELYRA_RUN_NAME:              test-ram-units-20221003T000000
...

Reviewed output of make docs

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@kiersten-stokes kiersten-stokes added this to the 3.12.0 milestone Oct 4, 2022
@elyra-bot
Copy link

elyra-bot bot commented Oct 4, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit 4e8492c into elyra-ai:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants