Skip to content

Update release script container builds #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2022
+11 −9
Merged

Update release script container builds #2891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6664f47
Update release script container builds
akchinSTC Aug 19, 2022
8f248cc
remove redundant check
akchinSTC Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions create-release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,10 +465,11 @@ def build_release():
# Build wheels and source packages
check_run(["make", "release"], cwd=config.source_dir, capture_output=False)

# Build container images from tagged release
check_run(["git", "checkout", f"tags/v{config.new_version}"], cwd=config.source_dir, capture_output=False)
check_run(["make", "container-images"], cwd=config.source_dir, capture_output=False)
check_run(["git", "checkout", "main"], cwd=config.source_dir, capture_output=False)
if not config.pre_release:
# Build container images from tagged release
check_run(["git", "checkout", f"tags/v{config.new_version}"], cwd=config.source_dir, capture_output=False)
check_run(["make", "container-images"], cwd=config.source_dir, capture_output=False)
check_run(["git", "checkout", "main"], cwd=config.source_dir, capture_output=False)

print("")

Expand Down Expand Up @@ -848,11 +849,12 @@ def publish_release(working_dir) -> None:
print("-----------------------------------------------------------------")
# push container images
print()
print(f"Pushing container images")
is_latest = config.git_branch == "main" and not config.pre_release
check_run(["git", "checkout", f"tags/v{config.new_version}"], cwd=config.source_dir, capture_output=False)
check_run(["make", "publish-container-images", f"IMAGE_IS_LATEST={is_latest}"], cwd=config.source_dir)
check_run(["git", "checkout", "main"], cwd=config.source_dir, capture_output=False)
if not config.pre_release:
print(f"Pushing container images")
is_latest = config.git_branch == "main"
check_run(["git", "checkout", f"tags/v{config.new_version}"], cwd=config.source_dir, capture_output=False)
check_run(["make", "publish-container-images", f"IMAGE_IS_LATEST={is_latest}"], cwd=config.source_dir)
check_run(["git", "checkout", "main"], cwd=config.source_dir, capture_output=False)


def initialize_config(args=None) -> SimpleNamespace:
Expand Down