Skip to content

Conversation

@akchinSTC
Copy link
Member

Fixes #2859

What changes were proposed in this pull request?

How was this pull request tested?

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Aug 17, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC added the area:documentation Improvements or additions to documentation label Aug 17, 2022
@akchinSTC akchinSTC added this to the 3.11.0 milestone Aug 18, 2022
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @akchinSTC.

@ptitzler
Copy link
Member

I've pushed a change to the README that fixes markdown rendering issues, such as indentation and numbering. I've also added <...> around placeholders everywhere to improve clarity, e.g. image_name => <image_name>. It would have taken me just as long to describe the issues ...

Before:

image

After:

image

@ptitzler
Copy link
Member

ptitzler commented Aug 19, 2022

In my environment the container won't start:

$ docker images
REPOSITORY                         TAG       IMAGE ID       CREATED         SIZE
image_name                         tag       5c36ea1ea69c   9 minutes ago   1.23GB

$ docker run -t image_name:tag -v /Users/patti/temp/elyra/:/dev/elyra -p 8888:8888
[FATAL tini (7)] exec -v failed: No such file or directory

$ ls /Users/patti/temp/elyra/
CONTRIBUTING.md		conftest.py		package.json		test_requirements.txt
...

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit 3cec17f into elyra-ai:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation for dev container image

4 participants