Skip to content

Conversation

@ptitzler
Copy link
Member

@ptitzler ptitzler commented Aug 16, 2022

Fixes

$ make lint-server
python3 -m flake8 elyra .github
elyra/tests/pipeline/test_handlers.py:33:1: I100 Import statements are in the wrong order. 'from elyra.pipeline.processor import PipelineProcessorManager' should be before 'from elyra.tests.util.handlers_utils import expected_http_error'
elyra/tests/pipeline/test_handlers.py:33:1: I202 Additional newline in a group of imports. 'from elyra.pipeline.processor import PipelineProcessorManager' is identified as Application and 'from elyra.tests.util.handlers_utils import expected_http_error' is identified as Application.
elyra/tests/pipeline/test_handlers.py:36:1: I100 Import statements are in the wrong order. 'from elyra.pipeline.parser import PipelineParser' should be before 'from elyra.pipeline.validation import ValidationResponse'
make: *** [lint-server] Error 1

which was introduced in https://github.com/elyra-ai/elyra/pull/2876/files

What changes were proposed in this pull request?

  • Fix import order and grouping

How was this pull request tested?

$ make lint-server

CI task output:

image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:bug Something isn't working component:build build and build related issues(dependencies and docker) labels Aug 16, 2022
@ptitzler ptitzler added this to the 3.11.0 milestone Aug 16, 2022
@elyra-bot
Copy link

elyra-bot bot commented Aug 16, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC linked an issue Aug 16, 2022 that may be closed by this pull request
@akchinSTC akchinSTC merged commit 1d412e9 into elyra-ai:main Aug 16, 2022
@ptitzler ptitzler deleted the fix-lint-errors branch August 17, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:build build and build related issues(dependencies and docker) kind:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants