Dev workflow documentation updates#2832
Conversation
|
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
kiersten-stokes
left a comment
There was a problem hiding this comment.
LGTM! This will be good to have back in the docs to streamline future installations. Thanks!
kevin-bates
left a comment
There was a problem hiding this comment.
This PR looks great. I'm wondering, though, if we could add one more thing that just came up in this discussion? If not, no big deal - it could be tackled another time.
I think this would amount to:
- adding a link to
GNU Maketo the Requirements section. - adding installation instructions - which would probably be best to just defer to the previously linked web page for their platform.
- adding a verification step to run
makefrom the github directory (and reference the output that is a couple sections below in Build & Installation
|
Sounds fair, |
|
@salonee13 - you're probably busy making changes to the community repository. Let us know if you are unable to get to this before semester end and we can merge as is. |
kevin-bates
left a comment
There was a problem hiding this comment.
This looks good. Thank you for adding the information regarding make. I had a small comment regarding the time and location in which the make installation is verified.
Co-authored-by: Kevin Bates <kbates4@gmail.com>
What changes were proposed in this pull request?
Added lines to documentation to have the contributor check to see if they have yarn and node installed correctly.
How was this pull request tested?
Reviewed the page after make docs
Developer's Certificate of Origin 1.1