Skip to content

Add Korean localization and Korean 2-set keyboard layout#99

Merged
elvissteinjr merged 2 commits intoelvissteinjr:masterfrom
hisacat:master
Aug 26, 2025
Merged

Add Korean localization and Korean 2-set keyboard layout#99
elvissteinjr merged 2 commits intoelvissteinjr:masterfrom
hisacat:master

Conversation

@hisacat
Copy link
Contributor

@hisacat hisacat commented Aug 23, 2025

First of all, thank you for creating such a great program.

This PR adds the following changes for Korean users:

  • Korean translation file
  • Korean 2-set keyboard layout

Korean localization Korean 2-set keyboard layout

Please review and merge if it looks good.
I hope this project continues to be helpful to even more users in the future 😄

@elvissteinjr
Copy link
Owner

I can't see anything wrong with this, so no reason to not just straight up merge this.
I'll assume the keyboard works fine and as expected on Korean systems since I can't really judge this. But you wouldn't have done this without reason so, yeah.

Thank you for your help!

@elvissteinjr elvissteinjr merged commit ea38e97 into elvissteinjr:master Aug 26, 2025
@hisacat
Copy link
Contributor Author

hisacat commented Aug 28, 2025

Yep!
just to give a brief explanation:

On a standard Korean keyboard, the "한/영 key" (0x15: VK_KANA/VK_HANGUL) is used to switch between Korean and English input modes.
Since there is no direct way to access the currently selected IME state or input mode, I simply adopted the layout of a typical Korean physical keyboard

image

Thanks again! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants