Use both language and country code for auto language detection#90
Merged
elvissteinjr merged 1 commit intoelvissteinjr:masterfrom Mar 15, 2025
Merged
Use both language and country code for auto language detection#90elvissteinjr merged 1 commit intoelvissteinjr:masterfrom
elvissteinjr merged 1 commit intoelvissteinjr:masterfrom
Conversation
Owner
|
Definitely a oversight for ISO 363 macrolanguages. The change looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use both the language and country codes for automatic language detection.
This will be useful for languages with multiple variants where the language code alone is not capable of distinguishing between them. The code will first check if a translation file with the country code (e.g., en_US.ini) exists; if not, it will fall back to using the language code only (e.g., en.ini).