Add Japanese keyboard (JIS) layout#103
Conversation
|
Hi! Thank you for your contribution. IME handling should work for desktop input. Not sure if it's working correctly for the VR UI input fields or browser overlays. Need to check still but that would be an issue for me to handle. As for the layout itself, I can't comment on the Japanese part of it so I'll just assume it's right and working on Japanese systems. The Enter key looks like it should be in an ISO-Enter shape. Desktop+ does allow for that key shape even if it's a bit unintuitive. Basically have two keys of the type "Virtual Key (ISO-Enter)", with the first one in the upper row spanning the full width and the second one on the row below it will automatically stretch above it. This is more minor and subjective to a degree, but on the numpad the Page Up/Down key labels are in all caps "PG UP/DN" while the ones in the navigation cluster are camel case "PgUp/Dn". I'm not really seeing a reason not to have these labels be the same for consistency. Everything else looks fine to me. |
- Use ISOEnter key shape for Enter - Unify PgUp/PgDn labels - Adjust numpad 5 label alignment
jf9tgl
left a comment
There was a problem hiding this comment.
Thank you for your review!
I've adjusted the layout.
Also, I was able to input Japanese correctly using Google Japanese Input and Microsoft IME on my system.
|
There's one more thing actually. I should've seen it the first time, sorry about that. Otherwise it looks good to me. For now I'd say desktop input works and that's the most important thing. And again, it's not the fault of the keyboard layout anyways. |
Yes, it is intentional, assuming "" represents a backslash. Additionally, the hiragana key appears to output VK_OEM_ATTN (240) to enter full-width (Romaji input) mode rather than IME_KANA (21), so I've corrected that. |
|
I went ahead and merged since it looked good to me. But let me know if you have any other changes you want merged. |
Hello!

I've added a new keyboard layout for Japanese users.
This layout includes a kanji key, which enables smoother switching between Romaji input and alphabet input.
The mechanism involves sending
VK_KANJIto toggle the IME state.This keyboard layout adheres to the JIS standard.