refactor(examples): attempt to improve clarity of where some hard-coded numbers coming from or mean #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….max/1 over literal
grzuy
force-pushed
the
example-legibility
branch
from
ca053b1 to
bb027bf
Compare
grzuy
force-pushed
the
example-legibility
branch
3 times, most recently
from
8ca4d7b to
89bc619
Compare
grzuy
force-pushed
the
example-legibility
branch
from
89bc619 to
ab0b500
Compare
Contributor
Author
|
Test failure seems to be also present in last |
polvalente
reviewed
Jul 17, 2023
msluszniak
reviewed
Jul 17, 2023
Co-authored-by: Mateusz Sluszniak <[email protected]>
Co-authored-by: Mateusz Sluszniak <[email protected]>
This reverts commit 3420b8c.
This reverts commit aee2acf.
grzuy
force-pushed
the
example-legibility
branch
from
9c82a22 to
13f6662
Compare
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought something like this may help improve understanding of these model examples for first-time readers.
From my own experience when first reading these a while ago, the most challenging thing at first was understanding what hard-coded values meant or where they were coming from, and how and if they where related with each other.