Vendor Jason library #258
Merged
Vendor Jason library #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vendor the Jason library so that the version of Jason used by ElixirLS does not conflict with the version used by the end-users code. Right now one will win out over the other which can lead to issues. Luckily since Jason has been pretty stable there haven't been too many issues up to this point. Fixes #253
2 tasks
mix.lock
Outdated
| @@ -7,6 +7,7 @@ | |||
| "forms": {:hex, :forms, "0.0.1", "45f3b10b6f859f95f2c2c1a1de244d63855296d55ed8e93eb0dd116b3e86c4a6", [:rebar3], [], "hexpm", "530f63ed8ed5a171f744fc75bd69cb2e36496899d19dbef48101b4636b795868"}, | |||
| "getopt": {:hex, :getopt, "1.0.1", "c73a9fa687b217f2ff79f68a3b637711bb1936e712b521d8ce466b29cbf7808a", [:rebar3], [], "hexpm", "53e1ab83b9ceb65c9672d3e7a35b8092e9bdc9b3ee80721471a161c10c59959c"}, | |||
| "jason": {:hex, :jason, "1.2.1", "12b22825e22f468c02eb3e4b9985f3d0cb8dc40b9bd704730efa11abd2708c44", [:mix], [{:decimal, "~> 1.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "b659b8571deedf60f79c5a608e15414085fa141344e2716fbd6988a084b5f993"}, | |||
Collaborator
There was a problem hiding this comment.
Is the original jason still required by some other dependancy?
There was a problem hiding this comment.
The little forgotten mix deps.unlock --unused can remove the stale info from the lock file.
Member
Author
There was a problem hiding this comment.
Ah, good catch. I always forget to run mix deps.unlock --unused
lukaszsamson
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor the Jason library so that the version of Jason used by ElixirLS does not conflict with the version used by the end-users code. Right now one will win out over the other which can lead to issues. Luckily since Jason has been pretty stable there haven't been too many issues up to this point.
Pulls the vendored version of Jason from https://github.com/elixir-lsp/jason
Fixes #253