chore: reduce log output during unit testing #2320
Conversation
jo-elimu
requested review from
AshishBagdane,
nya-elimu and
tomaszsmy
and removed request for
a team
WalkthroughThe changes include updating the Maven project version in the dependency tree file and downgrading log statements from INFO to DEBUG level in two methods within a utility class. No other functional, structural, or dependency changes are present. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/main/java/ai/elimu/util/epub/EPubParagraphExtractionHelper.java (1)
351-352: UnconditionalSystem.out.printlndefeats the noise-reduction goal.
System.out.println("paragraph: " + paragraph);will always print, regardless of log configuration, spamming test output. Replace with alog.debug(or remove entirely).- System.out.println("paragraph: " + paragraph); + // Use DEBUG level to avoid console noise during tests + log.debug("paragraph: {}", paragraph);
🧹 Nitpick comments (1)
src/main/java/ai/elimu/util/epub/EPubParagraphExtractionHelper.java (1)
34-36: Consider downgrading this INFO log as well.Line 35 still emits at INFO level (
extractParagraphsFromChapter). Given the PR goal of reducing unit-test noise, it probably deservesDEBUGlike the other statements you just changed.- log.info("extractParagraphsFromChapter"); + log.debug("extractParagraphsFromChapter");
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pom-dependency-tree.txt(1 hunks)src/main/java/ai/elimu/util/epub/EPubParagraphExtractionHelper.java(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
pom-dependency-tree.txt (2)
Learnt from: jo-elimu
PR: elimu-ai/webapp#0
File: :0-0
Timestamp: 2025-05-03T08:01:30.217Z
Learning: The elimu-ai/webapp repository has a dependency on ai.elimu:model (version 2.0.97) that provides shared model classes and enums. The Language enum should be imported from ai.elimu.model.v2.enums.Language instead of creating local duplicates.
Learnt from: jo-elimu
PR: #2312
File: src/main/java/ai/elimu/entity/analytics/LetterSoundLearningEvent.java:19-31
Timestamp: 2025-07-27T03:40:02.040Z
Learning: In the elimu.ai webapp project, the database schema file at src/main/resources/META-INF/jpa-schema-export.sql is auto-generated from JPA entity annotations, so manual updates to this file are not needed when adding new entity fields.
🔇 Additional comments (3)
pom-dependency-tree.txt (1)
1-1: Project version bump looks fine.Only the root artifact version is updated from
2.6.113-SNAPSHOTto2.6.114-SNAPSHOT; the rest of the tree is untouched, so no dependency-resolution side-effects are expected.src/main/java/ai/elimu/util/epub/EPubParagraphExtractionHelper.java (2)
238-239: Log level downgrade LGTM.
processParagraphNodenow logs at DEBUG, consistent with the PR objective.
304-306: Log level downgrade LGTM.
getCleanedUpParagraphnow logs at DEBUG; change is correct and side-effect-free.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
=========================================
Coverage 17.13% 17.13%
Complexity 461 461
=========================================
Files 260 260
Lines 7734 7734
Branches 900 900
=========================================
Hits 1325 1325
Misses 6326 6326
Partials 83 83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue Number
Purpose
Technical Details
Testing Instructions
Screenshots
Format Checks
Note
Files in PRs are automatically checked for format violations with
mvn spotless:check.If this PR contains files with format violations, run
mvn spotless:applyto fix them.