Cycles node setup improvements #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cc0textures import Was broken by a design change of the third party texture provider
Add compatibility to removed color space options in 2.81
There is an intended mix of GPL and MIT licensed files.
Co-Authored-By: Elie Michel <[email protected]>
Use cc0textures xml output
This is copied from this Gist https://gist.github.com/ogierm/8f4107cc42cfc9eeb8dea0eaefe5a2b5 and was made in reference to eliemichel#15 (comment)
Co-Authored-By: Elie Michel <[email protected]>
This even makes it more concise and easier to read! 🤩 Code by @eliemichel
Fix pip installing lxml
Owner
|
^^ you don't have to if it pisses you. Thanks for continuing your work on this :) |
Contributor
Author
|
Haha it does kinda piss me as I can only reliably debug via asserts. The whole thing is the basis for later being able to maybe scrape models from 3DModelHaven, so I really want to get it done (plus it sharpens my python a bit 😂) |
…up-Generation-Improvements
Contributor
Author
|
Just tested the whole lxml thing from Linux and it does work for me there too (after the patch). Loading node groups from the file seems to work too and the groups are not being duplicated. |
While testing I noticed that the string list `names` in the previous version changed it's type at runtime to `bpy.types.ShaderNodeTree` and I couldn't explain why, there was no reassignment. Turns out that that context manager `with ... as ...` expression replaces the references in the list from pointing to strings, but to the actual datablocks that it imported. While it caused me quite some trouble to understand this behavior, it ultimately leads to much, much cleaner code here, as Blender already did already did all of the name - asset tracking I tried to do manually before.
benthillerkus
force-pushed
the
Node-Setup-Generation-Improvements
branch
from
0b068d3 to
9da6b72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch tries to incorporate the changes I've proposed in #53.