Fixed incorrect slicing when slice is 0 or null#63
Open
electerious wants to merge 1 commit into
Open
Conversation
It's currently not possibly to save a path with the value `0` because the if returns `false` when `obj[key]` is `0`. Caused me a lot of headache.
|
@elgerlambert Any idea on when this should be fixed and pushed out? Until that point, this is a blocker for me to use this in my application. Otherwise, it works really well! |
|
@jdt1204 you can use a custom slicer passed to const slicer = paths => state => {
const subset = {}
paths.forEach(path => {
// default implementation does a falsy check on state[path],
// which means false doesn't save hrmph
subset[path] = state[path]
})
return subset
}
compose(applyMiddleware(...middleware), persistState(localStorageProps, { slicer }), devTools) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's currently not possibly to save a path with the value
0ornullbecause the if returnsfalsewhenobj[key]is0ornull. Caused me a lot of headache.I saw you're already working on v1.0, but I hope you're releasing this a bugfix for the current version. It's causing a lot of trouble in my application.
Thanks!