perf(core): flatten demux filter chain into a vector#188
Merged
Conversation
9ce73ff to
5cc5a1a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
I've also tried using the |
Collaborator
|
I decided to merge these changes without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Demuxwith a flatSmallVecof filtersmailboxbenchmark measuring per-call cost ofsend/try_send(routed and direct) across 1–100 consumer groupsfullfeature for bench crate (needed forelfo-configurer)Previously each
route_towrapped the previous filter in a new closure, creating a recursive call chain. With many groups (50+) this caused overhead due to deep indirect calls and CPU cache misses. The flat vector iterates filters sequentially.Benchmark results
send_routed(ns per call, system allocator):try_send_routed(ns per call, system allocator):Test plan
mailbox_sysbenchmark passes (cargo bench --bench mailbox_sys -- --test)messaging_sysbenchmark compiles and runs