Unprefix room_version & encryption from hierarchy API#19576
Merged
MadLittleMods merged 5 commits intoelement-hq:developfrom Mar 31, 2026
Merged
Unprefix room_version & encryption from hierarchy API#19576MadLittleMods merged 5 commits intoelement-hq:developfrom
MadLittleMods merged 5 commits intoelement-hq:developfrom
Conversation
Part of MSC3266. This doesn't stabilise the room summary API yet.
|
|
MadLittleMods
approved these changes
Mar 30, 2026
| "encryption": stats.encryption, | ||
| } | ||
|
|
||
| if self._msc3266_enabled: |
Contributor
There was a problem hiding this comment.
👍 This is an iterative step towards stabilizing MSC3266
In the name of iteration, we can push this through. Might be slightly weird for people who expect msc3266_enabled to still control this kind of thing since it's still in the codebase for another small piece.
Contributor
|
Thanks for moving things forward @cloudrac3r 🐠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These seem to work properly in the hierarchy API so I figured I'd unprefix them and remove the flag requirement. This should better align with the spec and Matrix v1.15 (via MSC3266), which says these properties are available and named like this.
Related to #18731.
This doesn't affect the stability or experimental flags of the room summary API, just the hierarchy API.
Pull Request Checklist
Keywords: MSC3266, Matrix v1.15.