Skip to content

Fix /sync timeline state duplicated in state when lazy-loading#19464

Draft
MadLittleMods wants to merge 3 commits intodevelopfrom
madlittlemods/fix-sync-state-duplication
Draft

Fix /sync timeline state duplicated in state when lazy-loading#19464
MadLittleMods wants to merge 3 commits intodevelopfrom
madlittlemods/fix-sync-state-duplication

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Feb 13, 2026

Fix /sync timeline state duplicated in state when lazy-loading

Noticed while working on #19463

Related to #18793 as "[...] I wouldn't expect the leave event to be in the state block because in non-msc4222 mode, state events in the timeline block are added to state and don't need to be duplicated, so that's fun. It's not really what this bug is about, but included for context nonetheless."

Dev notes

Looks like this regressed in matrix-org/synapse#13477 (2022-08-18)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@MadLittleMods MadLittleMods changed the title Fix /sync timeline state duplicated in state Fix /sync timeline state duplicated in state when lazy-loading Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant