Fix /sync timeline state duplicated in state when lazy-loading#19464
Draft
MadLittleMods wants to merge 3 commits intodevelopfrom
Draft
Fix /sync timeline state duplicated in state when lazy-loading#19464MadLittleMods wants to merge 3 commits intodevelopfrom
/sync timeline state duplicated in state when lazy-loading#19464MadLittleMods wants to merge 3 commits intodevelopfrom
Conversation
3 tasks
/sync timeline state duplicated in state/sync timeline state duplicated in state when lazy-loading
5 tasks
Conflicts: synapse/handlers/sync.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
/synctimelinestate duplicated instatewhen lazy-loadingNoticed while working on #19463
Related to #18793 as "[...] I wouldn't expect the leave event to be in the
stateblock because in non-msc4222 mode, state events in thetimelineblock are added tostateand don't need to be duplicated, so that's fun. It's not really what this bug is about, but included for context nonetheless."Dev notes
Looks like this regressed in matrix-org/synapse#13477 (2022-08-18)
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.