Skip to content

Log if we ever gc.freeze() #19440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MadLittleMods merged 2 commits into from
Feb 25, 2026
Merged

Log if we ever gc.freeze() #19440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e67e530
Log if we ever `gc.freeze()`
MadLittleMods Feb 6, 2026
07d791d
Add changelog
MadLittleMods Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/19440.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add log to explain when and why we freeze objects in the garbage collector.
5 changes: 5 additions & 0 deletions synapse/app/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,11 @@ def log_shutdown() -> None:
#
# PyPy does not (yet?) implement gc.freeze()
if hasattr(gc, "freeze"):
logger.info(
"garbage collector: Freezing all allocated objects in the hopes that (almost) "
"everything currently allocated are things that will be used by the homeserver "
"for the rest of time. Doing so means less work each GC (hopefully)."
)
Comment on lines +779 to +783
Copy link
Copy Markdown
Contributor Author

@MadLittleMods MadLittleMods Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same language used in the comment above. I think it's worth having some explanation here.

gc.collect()
gc.freeze()

Expand Down
Loading