Transform events with client metadata before serialising in /event response.#19340
Merged
reivilibre merged 4 commits intodevelopfrom Jan 6, 2026
Merged
Transform events with client metadata before serialising in /event response.#19340reivilibre merged 4 commits intodevelopfrom
reivilibre merged 4 commits intodevelopfrom
Conversation
Not aware of an actual issue here, but seems silly to bypass it
devonh
approved these changes
Jan 6, 2026
Member
devonh
left a comment
devonh
left a comment
There was a problem hiding this comment.
These changes look appropriate to me.
Nice find!
reivilibre
added a commit
that referenced
this pull request
Feb 11, 2026
Part of: MSC4354 whose experimental feature tracking issue is #19409 Follows: #19340 (a necessary bugfix for `/event/` to set this metadata) Partially supersedes: #18968 This PR implements the first batch of work to support MSC4354 Sticky Events. Sticky events are events that have been configured with a finite 'stickiness' duration, capped to 1 hour per current MSC draft. Whilst an event is sticky, we provide stronger delivery guarantees for the event, both to our clients and to remote homeservers, essentially making it reliable delivery as long as we have a functional connection to the client/server and until the stickiness expires. This PR merely supports creating sticky events and receiving the sticky TTL metadata in clients. It is not suitable for trialling sticky events since none of the other semantics are implemented. Contains a temporary SQLite workaround due to a bug in our supported version enforcement: #19452 --------- Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org> Co-authored-by: Eric Eastwood <erice@element.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is intended for commit-by-commit review; at least the last commit in the series is going to be best standalone.
Original commit schedule, with full messages:
Fix /event/ endpoint not transforming event with per-requester metadata
Pass notif_event through filter_events_for_client
Not aware of an actual issue here, but seems silly to bypass it
Call it filter_and_transform_events_for_client to make it more obvious