-
Notifications
You must be signed in to change notification settings - Fork 503
Implement synapse issue #16751: Treat local_media_directory as optional storage provider #19204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anoadragon453
merged 19 commits into
element-hq:develop
from
drallgood:implement-issue-16751-local-media-provider
Jan 6, 2026
Merged
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2e78aa8
Implement synapse issue #16751: Treat local_media_directory as option…
drallgood 7cc0aeb
Implement synapse issue #16751: Treat local_media_directory as option…
drallgood 8eed314
Revert lint.sh formatting changes
drallgood b6ffef6
Fix mypy error for local_media_directory type annotation
drallgood ccc047d
Merge branch 'develop' into implement-issue-16751-local-media-provider
drallgood 5d272af
Refactor MediaStorage to accept local_provider as optional argument
drallgood 646a051
Convert ensure_media_is_in_local_cache to async context manager
drallgood 94c4358
Document enable_local_media_storage config option
drallgood f63c91a
Merge branch 'develop' into implement-issue-16751-local-media-provider
drallgood 99eb251
Fix lint formatting in media_repository
drallgood af958d3
Merge branch 'develop' into implement-issue-16751-local-media-provider
drallgood 316e514
Fix race condition in concurrent remote media downloads
drallgood c957ae9
Merge branch 'develop' into implement-issue-16751-local-media-provider
drallgood 635c4cc
Update tests/replication/test_multi_media_repo.py
drallgood 8992d11
Apply suggestions from code review
drallgood 84bb64f
Add documentation warning for enable_local_media_storage configuration
drallgood fedda30
Merge branch 'develop' into implement-issue-16751-local-media-provider
drallgood 96b6703
Add warning log when no media storage backends are configured
drallgood 9459809
Regenerate config documentation
anoadragon453 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Made the local media directory optional by treating it as a storage provider. This allows off-site media storage without local cache, where media is stored directly to remote providers only, with temporary files used for thumbnail generation when needed. Contributed by Patrice Brend'amour @dr.allgood. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.