Restore printing sentinel for log_record.request#19172
Merged
MadLittleMods merged 3 commits intodevelopfrom Nov 13, 2025
Merged
Restore printing sentinel for log_record.request#19172MadLittleMods merged 3 commits intodevelopfrom
sentinel for log_record.request#19172MadLittleMods merged 3 commits intodevelopfrom
Conversation
MadLittleMods
commented
Nov 12, 2025
| True to include the record in the log output. | ||
| """ | ||
| context = current_context() | ||
| record.request = self._default_request |
Contributor
Author
There was a problem hiding this comment.
To explain the bug, we would default record.request to an empty string here, and then when we later used safe_set("request", str(context)) below, it would see our default value and not clobber it to sentinel.
This only results in an empty string getting printed whereas the prior art was to print sentinel which this PR restores.
sentinel for log_record.requestsentinel for log_record.request
sentinel for log_record.requestsentinel for log_record.request
reivilibre
approved these changes
Nov 13, 2025
Contributor
Author
|
Thanks for the review @reivilibre 🐆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore printing
sentinelforlog_record.requestThis was unintentionally changed in #19068.
There is no real bug here. Without this PR, we just printed an empty string for the
sentinellogcontext whereas the prior art behavior was to printsentinelwhich this PR restores.Found while staring at the logs in #19165
Reproduction strategy
poetry run synapse_homeserver --config-path homeserver.yamlasyncio - 64 - DEBUG - - Using selector: EpollSelectorlog line (notice empty string- -)asyncio - 64 - DEBUG - sentinel - Using selector: EpollSelector(noticesentinel)Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.