Allow /rooms/ admin API to be on workers#18360
Merged
erikjohnston merged 3 commits intodevelopfrom Apr 25, 2025
Merged
Conversation
anoadragon453
requested changes
Apr 25, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Do we need to do anything to route requests to this endpoint in Complement worker tests?
Member
Author
Alas, we don't test admin endpoints in complement |
anoadragon453
approved these changes
Apr 25, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Alas, we don't test admin endpoints in complement
Oh duh, indeed we do not.
LGTM assuming matrix-org/sytest#1400 passes CI.
MatMaul
pushed a commit
to tchapgouv/synapse
that referenced
this pull request
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by matrix-org/sytest#1400