Add heroes and room summary fields to Sliding Sync /sync#17419
Merged
MadLittleMods merged 22 commits intodevelopfrom Jul 11, 2024
Merged
Add heroes and room summary fields to Sliding Sync /sync#17419MadLittleMods merged 22 commits intodevelopfrom
heroes and room summary fields to Sliding Sync /sync#17419MadLittleMods merged 22 commits intodevelopfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
heroesand room summary fields (joined_count,invited_count) to Sliding Sync/syncBased on MSC3575: Sliding Sync
Dev notes
Instead of returning stripped state for
heroes, we could simply return the User ID's of the heroes like Sync v2 (seem.heroes) and return the full membership event inrequired_state, see matrix-org/matrix-spec-proposals#3575 (comment)We don't even have access to
heroesif we're the first person on our server to be invited to a remote room over federation, see matrix-org/matrix-spec-proposals#3575 (comment)Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)