Skip to content

Add heroes and room summary fields to Sliding Sync /sync#17419

Merged
MadLittleMods merged 22 commits intodevelopfrom
madlittlemods/sliding-sync-heroes
Jul 11, 2024
Merged

Add heroes and room summary fields to Sliding Sync /sync#17419
MadLittleMods merged 22 commits intodevelopfrom
madlittlemods/sliding-sync-heroes

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Jul 8, 2024

Add heroes and room summary fields (joined_count, invited_count) to Sliding Sync /sync

Based on MSC3575: Sliding Sync

Dev notes

Instead of returning stripped state for heroes, we could simply return the User ID's of the heroes like Sync v2 (see m.heroes) and return the full membership event in required_state, see matrix-org/matrix-spec-proposals#3575 (comment)

We don't even have access to heroes if we're the first person on our server to be invited to a remote room over federation, see matrix-org/matrix-spec-proposals#3575 (comment)

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants