Closed
Conversation
turt2live
commented
Jul 8, 2024
| @@ -0,0 +1 @@ | |||
| Relax rate limiting behaviour on federated media downloads of unknown size. No newline at end of file | |||
Member
Author
There was a problem hiding this comment.
I'm not confident enough to say the issue is fully fixed, but it should be better for RC/release purposes.
3637cf0 to
5777ba4
Compare
5777ba4 to
4e494d8
Compare
Member
Author
|
Closing in favour of #17439 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17394 (I think/hope)
A more complete fix likely involves the use of a
Linearizerover the download endpoint, limiting the number of concurrent requests to ~6 from any one client. We would then only count against the requester's bucket once we know the size for sure instead of decrementing bymax_size. Instead, this PR tries to refund the difference back to the rate limit, allowing the user to request more media at the cost of being rate limited if they have several (assumed) large concurrent requests on the go. The hope is this is uncommon, and that downloads complete quick enough to refund the bucket.Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.(run the linters)