Skip to content

Register sliding sync under a different path #17331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikjohnston merged 5 commits into from
Jun 19, 2024
Merged

Register sliding sync under a different path #17331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cc9ce5e
Register sliding sync under a different path
erikjohnston Jun 19, 2024
522cf52
Newsfile
erikjohnston Jun 19, 2024
8b36fc5
Update changelog.d/17331.misc
erikjohnston Jun 19, 2024
895b186
Fix tests
erikjohnston Jun 19, 2024
6412389
Update changelog.d/17331.misc
erikjohnston Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/17331.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Change path of the experimental [MSC3575](https://github.com/matrix-org/matrix-spec-proposals/pull/3575) Sliding Sync implementation to `/org.matrix.simplified_msc3575/sync` since our simplified API is slightly incompatible with what's in the current MSC.
2 changes: 1 addition & 1 deletion synapse/rest/client/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ class SlidingSyncRestServlet(RestServlet):
"""

PATTERNS = client_patterns(
"/org.matrix.msc3575/sync$", releases=[], v1=False, unstable=True
"/org.matrix.simplified_msc3575/sync$", releases=[], v1=False, unstable=True
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the path for some of the tests as well.

Copy link
Copy Markdown
Member Author

@erikjohnston erikjohnston Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

)

def __init__(self, hs: "HomeServer"):
Expand Down
4 changes: 3 additions & 1 deletion tests/rest/client/test_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,7 +1228,9 @@ def default_config(self) -> JsonDict:

def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer) -> None:
self.store = hs.get_datastores().main
self.sync_endpoint = "/_matrix/client/unstable/org.matrix.msc3575/sync"
self.sync_endpoint = (
"/_matrix/client/unstable/org.matrix.simplified_msc3575/sync"
)
self.store = hs.get_datastores().main
self.event_sources = hs.get_event_sources()

Expand Down