Add a config to not send out device list updates for specific users#16909
Merged
erikjohnston merged 3 commits intodevelopfrom Feb 13, 2024
Merged
Add a config to not send out device list updates for specific users#16909erikjohnston merged 3 commits intodevelopfrom
erikjohnston merged 3 commits intodevelopfrom
Conversation
List of users not to send out device list updates for when they register new devices. This is useful to handle bot accounts. This is undocumented as its mostly a hack to test on matrix.org. Note: This will still send out device list updates if the device is later updated, e.g. end to end keys are added.
| @@ -0,0 +1 @@ | |||
| Add experimental config option to not send device list updates for specific users. | |||
Member
There was a problem hiding this comment.
This makes me think that the config should be under experimental_features. Should it be, even though it's not an MSC?
Member
Author
There was a problem hiding this comment.
Ermh, good Q, my gut says no TBH, but 🤷
Member
There was a problem hiding this comment.
I may reword the changelog to say "temporary" or "hidden" option instead then, as "experimental" sounds like it should live under experimental_features, though I understand not expanding the scope of that config option past MSCs.
Member
There was a problem hiding this comment.
...although, when attempting to insert those suggestions myself into the changelog, neither are as good as experimental.
I'm happy to keep it as "experimental", but I'd like to ensure we don't forget about it and never document it. Could you make a quick issue to come back whether we want to keep and document/remove it in the future?
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
anoadragon453
approved these changes
Feb 13, 2024
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 9, 2024
# Synapse 1.102.0 (2024-03-05) ### Bugfixes - Revert element-hq/synapse#16756, which caused incorrect notification counts on mobile clients since v1.100.0. ([\#16979](element-hq/synapse#16979)) # Synapse 1.102.0rc1 (2024-02-20) ### Features - A metric was added for emails sent by Synapse, broken down by type: `synapse_emails_sent_total`. Contributed by Remi Rampin. ([\#16881](element-hq/synapse#16881)) ### Bugfixes - Do not send multiple concurrent requests for keys for the same server. ([\#16894](element-hq/synapse#16894)) - Fix performance issue when joining very large rooms that can cause the server to lock up. Introduced in v1.100.0. ([\#16903](element-hq/synapse#16903)) - Always prefer unthreaded receipt when >1 exist ([MSC4102](matrix-org/matrix-spec-proposals#4102)). ([\#16927](element-hq/synapse#16927)) ### Improved Documentation - Fix a small typo in the Rooms section of the Admin API documentation. Contributed by @RainerZufall187. ([\#16857](element-hq/synapse#16857)) ### Internal Changes - Don't invalidate the entire event cache when we purge history. ([\#16905](element-hq/synapse#16905)) - Add experimental config option to not send device list updates for specific users. ([\#16909](element-hq/synapse#16909)) - Fix incorrect docker hub link in release script. ([\#16910](element-hq/synapse#16910)) ### Updates to locked dependencies * Bump attrs from 23.1.0 to 23.2.0. ([\#16899](element-hq/synapse#16899)) * Bump bcrypt from 4.0.1 to 4.1.2. ([\#16900](element-hq/synapse#16900)) * Bump pygithub from 2.1.1 to 2.2.0. ([\#16902](element-hq/synapse#16902)) * Bump sentry-sdk from 1.40.0 to 1.40.3. ([\#16898](element-hq/synapse#16898))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of users not to send out device list updates for when they register new devices. This is useful to handle bot accounts.
This is undocumented as its mostly a hack to test on matrix.org.
Note: This will still send out device list updates if the device is later updated, e.g. end to end keys are added.