Skip to content

Send an email if the address is already bound to an user account#16819

Merged
reivilibre merged 5 commits intoelement-hq:developfrom
tchapgouv:send-already-in-use-email
Apr 23, 2024
Merged

Send an email if the address is already bound to an user account#16819
reivilibre merged 5 commits intoelement-hq:developfrom
tchapgouv:send-already-in-use-email

Conversation

@mcalinghee
Copy link
Copy Markdown
Contributor

@mcalinghee mcalinghee commented Jan 16, 2024 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mcalinghee mcalinghee force-pushed the send-already-in-use-email branch from 40a0123 to cd903e6 Compare January 16, 2024 10:14
@MatMaul
Copy link
Copy Markdown
Contributor

MatMaul commented Jan 18, 2024

Outside of CLA signing it seems ready.

I am moving that out of draft for early review, we are waiting for the legal department to clear the CLA.

Thanks!

@MatMaul
Copy link
Copy Markdown
Contributor

MatMaul commented Jan 18, 2024 •
edited
Loading

AH, I can't move this from draft to ready to review, only people with write access can do this, this feels... weird?

I am not sure if this is a setting or GH default that we can't change.

@erikjohnston @reivilibre little ping on this since this PR will probably not be looked at until it's out of draft. Thanks !

image

@erikjohnston erikjohnston marked this pull request as ready for review January 19, 2024 09:20
@erikjohnston erikjohnston requested a review from a team as a code owner January 19, 2024 09:20
@reivilibre
Copy link
Copy Markdown
Contributor

reivilibre commented Jan 19, 2024

AH, I can't move this from draft to ready to review, only people with write access can do this, this feels... weird?

it's because it's not your PR, right? :-)

@MatMaul
Copy link
Copy Markdown
Contributor

MatMaul commented Jan 19, 2024

🤦 indeed probably, thanks for doing it.

@MatMaul MatMaul force-pushed the send-already-in-use-email branch from 25a2aac to d1388f3 Compare March 1, 2024 13:58
reivilibre
reivilibre approved these changes Mar 19, 2024
View reviewed changes
@odelcroi @reivilibre
remove useless html tag
2811dd1 
Co-authored-by: reivilibre <[email protected]>
@MatMaul
Copy link
Copy Markdown
Contributor

MatMaul commented Apr 23, 2024

@reivilibre any chance we get that merge ? Thanks !

@reivilibre reivilibre marked this pull request as draft April 23, 2024 13:38
@reivilibre reivilibre marked this pull request as ready for review April 23, 2024 13:51
@reivilibre
Copy link
Copy Markdown
Contributor

reivilibre commented Apr 23, 2024

@MatMaul @mcalinghee please can you push a commit to the branch to kick CI or something? I don't have the access to your branch to do that :)

@reivilibre reivilibre merged commit ae18123 into element-hq:develop Apr 23, 2024
hughns pushed a commit to hughns/synapse that referenced this pull request Apr 25, 2024
@mcalinghee @MatMaul
@odelcroi @hughns
Send an email if the address is already bound to an user account (ele…
4be54e0 
…ment-hq#16819)

Co-authored-by: Mathieu Velten <[email protected]>
Co-authored-by: Olivier D <[email protected]>
yingziwu added a commit to yingziwu/synapse that referenced this pull request May 3, 2024
@yingziwu
Merge tag 'v1.106.0' into develop
168c76e 
No significant changes since 1.106.0rc1.

- Send an email if the address is already bound to an user account. ([\#16819](element-hq/synapse#16819))
- Implement the rendezvous mechanism described by [MSC4108](matrix-org/matrix-spec-proposals#4108). ([\#17056](element-hq/synapse#17056))
- Support delegating the rendezvous mechanism described [MSC4108](matrix-org/matrix-spec-proposals#4108) to an external implementation. ([\#17086](element-hq/synapse#17086))

- Add validation to ensure that the `limit` parameter on `/publicRooms` is non-negative. ([\#16920](element-hq/synapse#16920))
- Return `400 M_NOT_JSON` upon receiving invalid JSON in query parameters across various client and admin endpoints, rather than an internal server error. ([\#16923](element-hq/synapse#16923))
- Make the CSAPI endpoint `/keys/device_signing/upload` idempotent. ([\#16943](element-hq/synapse#16943))
- Redact membership events if the user requested erasure upon deactivating. ([\#17076](element-hq/synapse#17076))

- Add a prompt in the contributing guide to manually configure icu4c. ([\#17069](element-hq/synapse#17069))
- Clarify what part of message retention is still experimental. ([\#17099](element-hq/synapse#17099))

- Use new receipts column to optimise receipt and push action SQL queries. Contributed by Nick @ Beeper (@Fizzadar). ([\#17032](element-hq/synapse#17032), [\#17096](element-hq/synapse#17096))
- Fix mypy with latest Twisted release. ([\#17036](element-hq/synapse#17036))
- Bump minimum supported Rust version to 1.66.0. ([\#17079](element-hq/synapse#17079))
- Add helpers to transform Twisted requests to Rust http Requests/Responses. ([\#17081](element-hq/synapse#17081))
- Fix type annotation for `visited_chains` after `mypy` upgrade. ([\#17125](element-hq/synapse#17125))

* Bump anyhow from 1.0.81 to 1.0.82. ([\#17095](element-hq/synapse#17095))
* Bump peaceiris/actions-gh-pages from 3.9.3 to 4.0.0. ([\#17087](element-hq/synapse#17087))
* Bump peaceiris/actions-mdbook from 1.2.0 to 2.0.0. ([\#17089](element-hq/synapse#17089))
* Bump pyasn1-modules from 0.3.0 to 0.4.0. ([\#17093](element-hq/synapse#17093))
* Bump pygithub from 2.2.0 to 2.3.0. ([\#17092](element-hq/synapse#17092))
* Bump ruff from 0.3.5 to 0.3.7. ([\#17094](element-hq/synapse#17094))
* Bump sigstore/cosign-installer from 3.4.0 to 3.5.0. ([\#17088](element-hq/synapse#17088))
* Bump twine from 4.0.2 to 5.0.0. ([\#17091](element-hq/synapse#17091))
* Bump types-pillow from 10.2.0.20240406 to 10.2.0.20240415. ([\#17090](element-hq/synapse#17090))
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 18, 2024
chat/matrix-synapse: Update to 1.109.0
7d8e970 
# Synapse 1.109.0 (2024-06-18)

- Add the ability to auto-accept invites on the behalf of users. See
  the
  [`auto_accept_invites`](https://element-hq.github.io/synapse/latest/usage/configuration/config_documentation.html#auto-accept-invites)
  config option for
  details. ([\#17147](element-hq/synapse#17147))

- Add experimental
  [MSC3575](matrix-org/matrix-spec-proposals#3575)
  Sliding Sync `/sync/e2ee` endpoint for to-device messages and device
  encryption
  info. ([\#17167](element-hq/synapse#17167))

- Support
  [MSC3916](matrix-org/matrix-spec-proposals#3916)
  by adding unstable media endpoints to
  `/_matrix/client`. ([\#17213](element-hq/synapse#17213))

- Add logging to tasks managed by the task scheduler, showing CPU and
  database
  usage. ([\#17219](element-hq/synapse#17219))


# Synapse 1.108.0 (2024-05-28)

- Add a feature that allows clients to query the configured federation
  whitelist. Disabled by
  default. ([\#16848](element-hq/synapse#16848),
  [\#17199](element-hq/synapse#17199))

- Add the ability to allow numeric user IDs with a specific prefix
  when in the CAS flow. Contributed by Aurélien
  Grimpard. ([\#17098](element-hq/synapse#17098))


Synapse 1.107.0 (2024-05-14)

- Add preliminary support for [MSC3823: Account
  Suspension](matrix-org/matrix-spec-proposals#3823).
  ([\#17051](element-hq/synapse#17051))

- Declare support for [Matrix
  v1.10](https://matrix.org/blog/2024/03/22/matrix-v1.10-release/). Contributed
  by
  @clokep. ([\#17082](element-hq/synapse#17082))

- Add support for [MSC4115: membership metadata on
  events](matrix-org/matrix-spec-proposals#4115).
  ([\#17104](element-hq/synapse#17104),
  [\#17137](element-hq/synapse#17137))


# Synapse 1.106.0 (2024-04-30)

- Send an email if the address is already bound to an user
  account. ([\#16819](element-hq/synapse#16819))

- Implement the rendezvous mechanism described by
  [MSC4108](matrix-org/matrix-spec-proposals#4108).
  ([\#17056](element-hq/synapse#17056))

- Support delegating the rendezvous mechanism described
  [MSC4108](matrix-org/matrix-spec-proposals#4108)
  to an external
  implementation. ([\#17086](element-hq/synapse#17086))
3nprob pushed a commit to 3nprob/synapse-dev that referenced this pull request May 5, 2025
Revert "Send an email if the address is already bound to an user acco…
d92f452 
…unt (element-hq#16819)"

This reverts commit ae18123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mcalinghee @CLAassistant @MatMaul @reivilibre @odelcroi