Skip to content

Synchronise the user locked flag to Synapse#5550

Merged
reivilibre merged 3 commits into
mainfrom
rei/provision_user_locked
Mar 17, 2026
Merged

Synchronise the user locked flag to Synapse#5550
reivilibre merged 3 commits into
mainfrom
rei/provision_user_locked

Conversation

@reivilibre
Copy link
Copy Markdown
Contributor

Companion PR: element-hq/synapse#19554

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 13, 2026

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1426ea4
Status: ✅  Deploy successful!
Preview URL: https://2463fdbe.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://rei-provision-user-locked.matrix-authentication-service-docs.pages.dev

View logs

@reivilibre reivilibre force-pushed the rei/provision_user_locked branch from 6b53f2c to 5b7b4d6 Compare March 16, 2026 14:10
@reivilibre reivilibre marked this pull request as ready for review March 16, 2026 14:15
@reivilibre reivilibre requested a review from a team as a code owner March 16, 2026 14:15
@reivilibre reivilibre added the Z-Build-Workflow Add this label to trigger a build workflow for this pull request label Mar 16, 2026
@github-actions github-actions Bot removed the Z-Build-Workflow Add this label to trigger a build workflow for this pull request label Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

A build for this PR at commit 2f6ab49 has been created through the Z-Build-Workflow label by reivilibre.

Docker image is available at:

  • ghcr.io/element-hq/matrix-authentication-service:pr-5550
  • ghcr.io/element-hq/matrix-authentication-service:sha-2f6ab49

Pre-built binaries are available through the workflow run artifacts.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we also had a synapse_legacy implementation, maybe some configurations are still using that, but also we should drop that one.

Comment thread crates/matrix/src/mock.rs
reivilibre added a commit to element-hq/synapse that referenced this pull request Mar 16, 2026
…w MAS to set the user locked status in Synapse. (#19554)

Companion PR:
element-hq/matrix-authentication-service#5550
to 1) send this flag
and 2) provision users proactively when their lock status changes.

---

Currently Synapse and MAS have two independent user lock
implementations. This PR makes it so that MAS can push its lock status
to Synapse when 'provisioning' the user.

Having the lock status in Synapse is useful for removing users from the
user directory
when they are locked.

There is otherwise no authentication requirement to have it in Synapse;
the enforcement is done
by MAS at token introspection time.

---------

Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
@reivilibre reivilibre requested a review from sandhose March 17, 2026 11:19
@reivilibre reivilibre force-pushed the rei/provision_user_locked branch from 0246066 to ba9ca90 Compare March 17, 2026 11:22
@reivilibre reivilibre enabled auto-merge March 17, 2026 11:25
@reivilibre reivilibre disabled auto-merge March 17, 2026 11:25
@reivilibre reivilibre enabled auto-merge March 17, 2026 11:25
@reivilibre reivilibre force-pushed the rei/provision_user_locked branch 2 times, most recently from a2f041f to fc2ce27 Compare March 17, 2026 11:40
@reivilibre reivilibre force-pushed the rei/provision_user_locked branch from fc2ce27 to 1426ea4 Compare March 17, 2026 11:44
@reivilibre reivilibre merged commit 10d26a8 into main Mar 17, 2026
17 checks passed
@reivilibre reivilibre deleted the rei/provision_user_locked branch March 17, 2026 11:52
@sandhose sandhose added the T-Enhancement New feature of request label Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Enhancement New feature of request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants