Add expires_in to introspection responses#4241
Merged
reivilibre merged 2 commits intomainfrom Mar 17, 2025
Merged
Conversation
Closes #4224 Corresponds to: element-hq/synapse#18231
reivilibre
force-pushed
the
rei/expires_in
branch
from
38731cb to
86a9ad3
Compare
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
910630c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30804163.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-expires-in.matrix-authentication-service-docs.pages.dev |
sandhose
requested changes
Mar 17, 2025
Member
sandhose
left a comment
sandhose
left a comment
There was a problem hiding this comment.
Other than the small serialisation tweak, lgtm
sandhose
approved these changes
Mar 17, 2025
reivilibre
added a commit
to element-hq/synapse
that referenced
this pull request
Apr 1, 2025
… Service integration (MSC3861) more efficient. (#18231) Evolution of cd78f3d This cache does not have any explicit invalidation, but this is deemed acceptable (see code comment). We may still prefer to add it eventually, letting us bump up the Time-To-Live (TTL) on the cache as we currently set a 2 minute expiry to balance the fact that we have no explicit invalidation. This cache makes several things more efficient: - reduces number of outbound requests from Synapse, reducing CPU utilisation + network I/O - reduces request handling time in Synapse, which improves client-visible latency - reduces load on MAS and its database --- Other than that, this PR also introduces support for `expires_in` (seconds) on the introspection response. This lets the cached responses expire at the proper expiry time of the access token, whilst avoiding clock skew issues. Corresponds to: element-hq/matrix-authentication-service#4241 --------- Signed-off-by: Olivier 'reivilibre <oliverw@matrix.org>
sandhose
added
A-Homeserver-Integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4224
Corresponds to: element-hq/synapse#18231