Skip to content

Add a feature flag for Simplified Sliding Sync.#3057

Merged
pixlwave merged 3 commits intodevelopfrom
doug/sss
Jul 18, 2024
Merged

Add a feature flag for Simplified Sliding Sync.#3057
pixlwave merged 3 commits intodevelopfrom
doug/sss

Conversation

@pixlwave
Copy link
Copy Markdown
Member

@pixlwave pixlwave commented Jul 17, 2024

Requires #3056 and matrix-org/matrix-rust-sdk#3723 (plus an SDK release).

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Jul 17, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 17, 2024 16:32
@pixlwave pixlwave requested review from stefanceriu and removed request for a team July 17, 2024 16:32
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 17, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 44a050e

@pixlwave pixlwave changed the title Add a feature flag for SSS. Add a feature flag for Simplified Sliding Sync. Jul 17, 2024
Copy link
Copy Markdown
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Base automatically changed from doug/builder-hook to develop July 18, 2024 08:47
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 77.88%. Comparing base (288d2c2) to head (44a050e).

Files Patch % Lines
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 7 Missing ⚠️
NSE/Sources/NotificationServiceExtension.swift 0.00% 4 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 3 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 2 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 1 Missing ⚠️
ElementX/Sources/Application/AppSettings.swift 0.00% 1 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 1 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 1 Missing ⚠️
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3057      +/-   ##
===========================================
- Coverage    77.96%   77.88%   -0.09%     
===========================================
  Files          694      694              
  Lines        54046    54099      +53     
===========================================
- Hits         42138    42136       -2     
- Misses       11908    11963      +55     
Flag Coverage Δ
unittests 68.61% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

@pixlwave pixlwave merged commit 2fb7f65 into develop Jul 18, 2024
@pixlwave pixlwave deleted the doug/sss branch July 18, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-wip for anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants