Skip to content

feat: Support matrix: links#4839

Merged
bmarty merged 1 commit intoelement-hq:developfrom
ShadowRZ:features/shadowrz/support-matrix-scheme-uri
Jun 9, 2025
Merged

feat: Support matrix: links#4839
bmarty merged 1 commit intoelement-hq:developfrom
ShadowRZ:features/shadowrz/support-matrix-scheme-uri

Conversation

@ShadowRZ
Copy link
Copy Markdown
Contributor

@ShadowRZ ShadowRZ commented Jun 7, 2025

Content

Supports matrix: links by delegating matrix: URI parsing to Rust SDK too

Motivation and context

Closes #4800

Screenshots / GIFs

Tests

  • Step 1: Use adb to open some matrix: links

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 15

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@ShadowRZ ShadowRZ requested a review from a team as a code owner June 7, 2025 07:20
@ShadowRZ ShadowRZ requested review from ganfra and removed request for a team June 7, 2025 07:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 7, 2025

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jun 7, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (de194e0) to head (725eccd).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
...es/matrix/impl/permalink/DefaultPermalinkParser.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4839      +/-   ##
===========================================
- Coverage    80.45%   80.44%   -0.01%     
===========================================
  Files         2140     2140              
  Lines        56773    56775       +2     
  Branches      7117     7118       +1     
===========================================
- Hits         45674    45672       -2     
- Misses        8664     8665       +1     
- Partials      2435     2438       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Ideally you could add some samples as bash files in this folder https://github.com/element-hq/element-x-android/tree/main/tools/adb, but it's not blocking from merging this PR. It both helps to document / test the feature.
Not blocking though!

@ShadowRZ ShadowRZ force-pushed the features/shadowrz/support-matrix-scheme-uri branch from 5e959e9 to 725eccd Compare June 9, 2025 11:49
@bmarty
Copy link
Copy Markdown
Member

bmarty commented Jun 9, 2025

For reference, this is "implementing" (the actual implementation is in the SDK) matrix-org/matrix-spec-proposals#2312 on Element X Android.

Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 20270cd into element-hq:develop Jun 9, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support matrix:/ URI schemes as per Matrix v1.2 spec

2 participants