Merged
Conversation
…as they caused multiple issues on linux
Member
Author
|
(builds on and replaces #6620) |
Member
Author
|
actually, it's not olm slowing down karma (removing it from webpack entirely only speeds things up by a few seconds). It's the 28MB of all-tests.js which is presumably bogging it down. |
Member
Author
|
(it's roughly 2x as slow as on webpack 2 :|) |
Member
Author
|
(and this is with |
so karma-webpack 3.0.5 is 4x slower than 4.0.0-beta.0 for webpacking for unknown reasons. However, 4.0.0-rc.1 and 4.0.0-rc.2 fail with a different error. So: pinned for now
Member
Author
|
n.b. 4.0.0-rc.[12] are broken due to codymikol/karma-webpack#363 |
Member
|
@ara4n this does work on Windows, and it feels faster than webpack 2 for me. Might be a slight difference in hardware though. |
Member
Author
|
LGTM'd irl from dave |
Contributor
|
Thanks for indirectly merging my few commits :) Awesome to see this merged |
Member
Author
|
thank you for doing all the hard work. i'm so sorry it took so long to merge :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update @MTRNord's Webpack4 for latest libs. Had to downgrade karma-webpack from 4.0.0-rc2 to 3.0.5 due to bugs in handling paths.
It works well on my Mac with node 10.9.0 (and npm 6.4.1), but
npm run testspends 58s in webpack from karma, probably re-packing Olm (even though webpack.config.js tells it not to). I'm going to ignore this given we're about to switch to WASM.@turt2live does this work on Windows? (karma-webpack 4 apparently is broken on Windows, hence also downgrading it here)