Show space name instead of 'Empty room' after creation#32886
Merged
t3chguy merged 3 commits intoelement-hq:developfrom Mar 23, 2026
Merged
Show space name instead of 'Empty room' after creation#32886t3chguy merged 3 commits intoelement-hq:developfrom
t3chguy merged 3 commits intoelement-hq:developfrom
Conversation
…reation When creating a new space, the setup screens showed 'Empty room' or 'New room' instead of the chosen name. The 'createSpace' function nested 'name' and 'topic' inside 'createOpts'. However, the creation flow expects them at the top level of the options object. This caused the name to be undefined. This patch modifies SpaceCreateMenu.tsx to move these properties to the top-level. It also updates SpaceCreateMenu-test.tsx with a regression test to verify the fix and prevent future regressions.
github-actions
bot
added
the
Z-Community-PR
There was a problem hiding this comment.
Pull request overview
Fixes a regression in the Space creation flow where the post-create screen could show fallback copy like “Empty room”/“New room” instead of the new Space’s intended name, by ensuring name/topic are provided in the shape expected by the shared createRoom helper.
Changes:
- Pass
nameandtopicas top-levelcreateRoomoptions increateSpace(instead of nesting them undercreateOpts). - Add a regression unit test asserting
name/topicare not nested undercreateOptswhen creating a Space.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/src/components/views/spaces/SpaceCreateMenu.tsx | Fixes the options object passed into createRoom so newly created Spaces carry name/topic in the expected fields. |
| apps/web/test/unit-tests/components/views/spaces/SpaceCreateMenu-test.tsx | Adds a regression test to prevent reintroducing incorrect nesting of name/topic under createOpts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
t3chguy
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Summary
This PR fixes an issue where a newly created Space would display as 'Empty room' or 'New room' instead of its intended name. The root cause was that the
nameandtopicproperties were being passed inside a nestedcreateOptsobject inSpaceCreateMenu.tsx. However, the creation flow expects these properties at the top level of the options object. This patch moves them to the correct level.Fixes
Fixes #32682
Type of change
Testing
SpaceCreateMenu-test.tsxto verify thatnameandtopicare correctly passed to the client during the space creation process.