Fix room list often showing the wrong icons for calls#32881
Merged
robintown merged 6 commits intoelement-hq:developfrom Mar 26, 2026
Merged
Fix room list often showing the wrong icons for calls#32881robintown merged 6 commits intoelement-hq:developfrom
robintown merged 6 commits intoelement-hq:developfrom
Conversation
robintown
force-pushed
the
call-type-reactivity
branch
from
f395ce8 to
1ad4463
Compare
robintown
force-pushed
the
call-type-reactivity
branch
from
1ad4463 to
4622027
Compare
robintown
force-pushed
the
call-type-reactivity
branch
from
4622027 to
6c17c92
Compare
Member
|
It seems to have caused regression (cf CI) |
Member
Author
|
Not a regression but indeed my testing efforts had a little flaw. Re-drafting for a sec. |
robintown
force-pushed
the
call-type-reactivity
branch
from
6c17c92 to
320a9b5
Compare
Besides improving accessibility, this makes it possible to check for the presence of a call indicator in the room list in Playwright tests.
robintown
force-pushed
the
call-type-reactivity
branch
from
320a9b5 to
741569e
Compare
To use the results of CallStore.getRoom reactively, you need to listen for Call events, not ConnectedCalls events.
robintown
force-pushed
the
call-type-reactivity
branch
from
741569e to
7165339
Compare
robintown
force-pushed
the
call-type-reactivity
branch
from
7165339 to
b6a2573
Compare
If a Call object is created by way of someone starting a voice call, then of course the call's initial type needs to be 'voice'.
The type of a call may change over time; therefore room list items explicitly need to react to the changes.
If we notify listeners of a change in a call's type before actually making that change, the listeners will be working with glitched state. This would cause the room list to show the wrong call type in certain situations.
robintown
force-pushed
the
call-type-reactivity
branch
from
b6a2573 to
d3dc0dd
Compare
BillCarsonFr
approved these changes
Mar 25, 2026
florianduros
approved these changes
Mar 25, 2026
auto-merge was automatically disabled
March 25, 2026 20:47
Pull request was closed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The room list displays either a telephone or video camera icon depending on the type of call taking place in a room. But there were
threefour distinct issues preventing the room list from actually showing the correct icon at all times.See commits for details; this begins with an accessibility improvement which I needed in order to even check the call type in our Playwright tests.