Strip ephemeral query params from OIDC redirect URI#32875
Merged
t3chguy merged 1 commit intoelement-hq:developfrom Mar 23, 2026
Merged
Strip ephemeral query params from OIDC redirect URI#32875t3chguy merged 1 commit intoelement-hq:developfrom
t3chguy merged 1 commit intoelement-hq:developfrom
Conversation
getOidcCallbackUrl() was building the redirect_uri from window.location.href, which may contain ephemeral params such as `updated` (appended on auto-update of element-web). This caused a redirect_uri mismatch on authorization servers.
github-actions
bot
added
the
Z-Community-PR
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
element-hq:develop
with commit Mar 23, 2026
aecdbc3
53 of 54 checks passed
Contributor
Author
|
Hi @t3chguy, thanks for reviewing and merging this. 🙇 |
Member
|
The process is anything on develop on the day of the RC is cut into the staging branch, then the release is just the RC plus any hotfixes. The RC is a week before the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getOidcCallbackUrlwas building the OIDC redirect_uri fromwindow.location.href, which may contain ephemeral params such asupdated(appended on auto-update of element-web). This caused a redirect_uri mismatch on authorization servers.Fixes #32874
Checklist